-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for python content type #17704
base: master
Are you sure you want to change the base?
Conversation
Can one of the admins verify this patch? |
d99a74a
to
b1edf96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening this! Looks good, added just one question which popped out.
b1edf96
to
eef673b
Compare
@vsedmik I cannot trigger the PRT could you trigger it? |
eef673b
to
e47fa37
Compare
I can, but it would fail with the current snap since we don't have |
96b0a5f
to
e833a1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dosas, could you update the test docstring as proposed?
I'm not sure when exactly we get the python support in downstream but I don't want to block your PR on it. This way we would skip the test until https://issues.redhat.com/browse/SAT-23430 moves to the Testing state.
e833a1f
to
cb641c1
Compare
cb641c1
to
cb7a8d4
Compare
Problem Statement
Missing python content type
Solution
Add python as content type and add simple happy flow test for sync
Related Issues
tests/foreman/api/test_repository.py::TestPythonRepository::test_positive_sync
-->