Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for python content type #17704

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dosas
Copy link
Collaborator

@dosas dosas commented Feb 27, 2025

Problem Statement

Missing python content type

Solution

Add python as content type and add simple happy flow test for sync

Related Issues

tests/foreman/api/test_repository.py::TestPythonRepository::test_positive_sync
-->

@dosas dosas requested review from a team as code owners February 27, 2025 13:46
@dosas dosas added CherryPick PR needs CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 6.17.z labels Feb 27, 2025
@Satellite-QE
Copy link
Collaborator

Can one of the admins verify this patch?

@dosas dosas force-pushed the feature/python-sync-test branch from d99a74a to b1edf96 Compare February 27, 2025 13:51
@dosas dosas requested review from ogajduse and vsedmik February 27, 2025 15:58
@dosas dosas changed the title Add tests for pyhton content type Add tests for python content type Mar 3, 2025
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this! Looks good, added just one question which popped out.

@dosas dosas force-pushed the feature/python-sync-test branch from b1edf96 to eef673b Compare March 5, 2025 10:45
@dosas dosas requested a review from vsedmik March 5, 2025 10:45
@dosas
Copy link
Collaborator Author

dosas commented Mar 5, 2025

@vsedmik I cannot trigger the PRT could you trigger it?

@dosas dosas force-pushed the feature/python-sync-test branch from eef673b to e47fa37 Compare March 5, 2025 10:46
@vsedmik
Copy link
Contributor

vsedmik commented Mar 5, 2025

@vsedmik I cannot trigger the PRT could you trigger it?

I can, but it would fail with the current snap since we don't have python content-type enabled in 6.17.
But we should get first snap for 6.18 soon.

@dosas dosas force-pushed the feature/python-sync-test branch 2 times, most recently from 96b0a5f to e833a1f Compare March 5, 2025 11:27
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dosas, could you update the test docstring as proposed?

I'm not sure when exactly we get the python support in downstream but I don't want to block your PR on it. This way we would skip the test until https://issues.redhat.com/browse/SAT-23430 moves to the Testing state.

@dosas dosas force-pushed the feature/python-sync-test branch from e833a1f to cb641c1 Compare March 11, 2025 18:46
@dosas dosas force-pushed the feature/python-sync-test branch from cb641c1 to cb7a8d4 Compare March 11, 2025 18:47
@dosas dosas requested a review from vsedmik March 11, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 6.17.z CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants