Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.16.z] Narrow down host's subscription status check #17380

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #17378

Problem Statement

It looks like the host's subscribed() property can potentially return wrong value from sys-purpose status.

# subscription-manager status
+-------------------------------------------+
   System Status Details
+-------------------------------------------+
Overall Status: Disabled
Content Access Mode is set to Simple Content Access. This host has access to content, regardless of subscription status.

System Purpose Status: Unknown

All credit goes to @jeremylenz who noticed this!

Solution

We should check the Overall Status specifically.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k test_positive_list_by_last_checkin

@Satellite-QE Satellite-QE added the 6.16.z Introduced in or relating directly to Satellite 6.16 label Jan 17, 2025
@Satellite-QE Satellite-QE requested a review from a team as a code owner January 17, 2025 20:13
@Satellite-QE Satellite-QE added Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Jan 17, 2025
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k test_positive_list_by_last_checkin

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Jan 17, 2025
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 9932
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py -k test_positive_list_by_last_checkin --external-logging
Test Result : ========== 1 passed, 95 deselected, 104 warnings in 816.92s (0:13:36) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jan 17, 2025
@Satellite-QE Satellite-QE merged commit 33cbce1 into 6.16.z Jan 17, 2025
16 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.16.z-ce06066bd284f52a186701d9d7136712a19eff89 branch January 17, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.16.z Introduced in or relating directly to Satellite 6.16 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants