addresses last of the policy hub items in issue #3633 #3654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for health-equity-tracker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
…atcherInstitute#3648) # Description and Motivation <!--- bulleted, high level items. use keywords (eg "closes SatcherInstitute#144" or "fixes #4323") --> Incremental migration from react-router-dom v5 to v6 following remix-run/react-router#8753 - installs compat package that runs both v5 and v6 apis - migrates WHAT IS HEALTH EQUITY and NEWS sub routes over to v6 via the compat package - once the whole app is via the compat package using v6 apis we can remove it and the components will work perfectly with v6 - extracts the text/icon from the HetTextArrowLink component, since we are using it on cards where the whole thing is linked, causing issues with nested `<a>`s. This way if we want the arrow on a larger linked item we can, or used on its own with the linking features and animation on hover ## Has this been tested? How? tests passing after updating their test routers to use compat as well ## Types of changes (leave all that apply) - Bug fix - Refactor / chore ## New frontend preview link is below in the Netlify comment 😎
…rce links, updates resource item index
benhammondmusic
requested changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
Has this been tested? How?
tests passing
Screenshots (if appropriate)
Types of changes
New frontend preview link is below in the Netlify comment 😎