Stops HET from throwing errors on missing breakdowns #3640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity-tracker into no-undefined-dataset
✅ Deploy Preview for health-equity-tracker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ity-tracker into no-undefined-dataset
✅ Deploy Preview for health-equity-tracker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ity-tracker into no-undefined-dataset
benhammondmusic
force-pushed
the
no-undefined-dataset
branch
from
e171145
to
d747706
Compare
eriwarr
approved these changes
Sep 10, 2024
kccrtv
pushed a commit
to kccrtv/health-equity-tracker
that referenced
this pull request
Sep 10, 2024
…e#3640) # Description and Motivation <!--- bulleted, high level items. use keywords (eg "closes SatcherInstitute#144" or "fixes #4323") --> Starts working on SatcherInstitute#3605 - rather than throwing an error when a datasetId isn't found, (like when a forced compare "age" breakdown tries to load data from a set with no age column like gun deaths of children), instead it just returns an empty response which triggers our normal missing data alerts that give context to which specific data is missing - fixes issue of duplicate disabled demographic type options in dropdown - deletes renamed DropDownMenu component ## Has this been tested? How? ## Screenshots (if appropriate) shows this rather than "OOPS SOMETHING WENT WRONG" <img width="1066" alt="Screenshot 2024-09-09 at 2 09 16 PM" src="https://github.com/user-attachments/assets/bf88cb60-ed4c-4f8e-8db4-0d5db145cbb7"> ## Types of changes (leave all that apply) - Bug fix ## New frontend preview link is below in the Netlify comment 😎
kccrtv
pushed a commit
to kccrtv/health-equity-tracker
that referenced
this pull request
Sep 10, 2024
…e#3640) # Description and Motivation <!--- bulleted, high level items. use keywords (eg "closes SatcherInstitute#144" or "fixes #4323") --> Starts working on SatcherInstitute#3605 - rather than throwing an error when a datasetId isn't found, (like when a forced compare "age" breakdown tries to load data from a set with no age column like gun deaths of children), instead it just returns an empty response which triggers our normal missing data alerts that give context to which specific data is missing - fixes issue of duplicate disabled demographic type options in dropdown - deletes renamed DropDownMenu component ## Has this been tested? How? ## Screenshots (if appropriate) shows this rather than "OOPS SOMETHING WENT WRONG" <img width="1066" alt="Screenshot 2024-09-09 at 2 09 16 PM" src="https://github.com/user-attachments/assets/bf88cb60-ed4c-4f8e-8db4-0d5db145cbb7"> ## Types of changes (leave all that apply) - Bug fix ## New frontend preview link is below in the Netlify comment 😎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
Starts working on #3605
Has this been tested? How?
Screenshots (if appropriate)
shows this rather than "OOPS SOMETHING WENT WRONG"
Types of changes
(leave all that apply)
New frontend preview link is below in the Netlify comment 😎