Fixes PHRMA Brffs frontend income sorting and unknown handling #3624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for health-equity-tracker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
eriwarr
approved these changes
Sep 5, 2024
kccrtv
pushed a commit
to kccrtv/health-equity-tracker
that referenced
this pull request
Sep 5, 2024
…erInstitute#3624) # Description and Motivation <!--- bulleted, high level items. use keywords (eg "closes SatcherInstitute#144" or "fixes #4323") --> closes SatcherInstitute#3601 - removes dataframe-js package that was accidentally added - keeps age-adj ratios from being shown on non-age, non-race breakdowns - sorts the demographic group dropdown by income the map card - removes the "Unknown income per 100k" from the simple bar chart - sorts by income for simple bar, comparison stacked bar, and table card. NOTE: I tried to get it to work to pre-sort the data earlier in the pipeline, and had lots of trouble. It's possible there is still a better way to do it than this where now it's loading it in each card and sorting it each of those times - fixes react key warnings - fixes meta data for _sex tables - general cleanup - allows downloadable data csvs to sort by income - adds tests for new incomeSorter - adds sortingUtils to clean up conditionals ## Has this been tested? How? - tests passing - manually confirmed ## Screenshots (if appropriate) Sorted Income groups <img width="1032" alt="Screenshot 2024-09-04 at 4 05 37 PM" src="https://github.com/user-attachments/assets/04023368-27cc-410c-8e48-554c43949233"> <img width="755" alt="Screenshot 2024-09-05 at 8 26 26 AM" src="https://github.com/user-attachments/assets/9d9f92fe-76d1-47b6-a577-454f16df2d1e"> <img width="755" alt="Screenshot 2024-09-05 at 8 27 10 AM" src="https://github.com/user-attachments/assets/0144efca-2fd8-47db-9295-7baf83181c73"> <img width="755" alt="Screenshot 2024-09-05 at 11 36 38 AM" src="https://github.com/user-attachments/assets/412aae80-ce1e-4f39-a527-3c62c01e53d5"> ## Types of changes (leave all that apply) - Bug fix - New content or feature ## New frontend preview link is below in the Netlify comment 😎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
closes #3601
Has this been tested? How?
Screenshots (if appropriate)
Sorted Income groups
Types of changes
(leave all that apply)
New frontend preview link is below in the Netlify comment 😎