Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend PHRMA Cancer: Adds _pct_share cols #3584

Merged

Conversation

benhammondmusic
Copy link
Collaborator

@benhammondmusic benhammondmusic commented Aug 23, 2024

Description and Motivation

  • part of Backend PHRMA Cancer Infra/Pipeline Setup #3579
  • extricate build_bq_col_types() in util function which scans df and automatically gets the metric cols based on suffixes
  • calcs pct_shares with or without "unknowns" based on the demographic breakdown and what's reflected in the source data
  • updates golden data with new cols

Has this been tested? How?

  • tests passing

Types of changes

(leave all that apply)

  • New content or feature

New frontend preview link is below in the Netlify comment 😎

Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for health-equity-tracker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b448ed4
🔍 Latest deploy log https://app.netlify.com/sites/health-equity-tracker/deploys/66c8ab2e385eeb0008c25d7f
😎 Deploy Preview https://deploy-preview-3584--health-equity-tracker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@benhammondmusic benhammondmusic marked this pull request as ready for review August 23, 2024 14:50
Copy link
Collaborator

@eriwarr eriwarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@benhammondmusic benhammondmusic merged commit 0b18d96 into SatcherInstitute:main Aug 23, 2024
8 checks passed
@benhammondmusic benhammondmusic deleted the phrma-brfss-pct-share branch August 23, 2024 15:45
kccrtv pushed a commit to kccrtv/health-equity-tracker that referenced this pull request Aug 27, 2024
# Description and Motivation
<!--- bulleted, high level items. use keywords (eg "closes SatcherInstitute#144" or
"fixes #4323") -->

- part of SatcherInstitute#3579
- extricate `build_bq_col_types()` in util function which scans df and
automatically gets the metric cols based on suffixes
- calcs pct_shares with or without "unknowns" based on the demographic
breakdown and what's reflected in the source data
- updates golden data with new cols

## Has this been tested? How?

- tests passing

## Types of changes

(leave all that apply)

- New content or feature

## New frontend preview link is below in the Netlify comment 😎

---------

Co-authored-by: Eric M Warren II <eric.m.warren1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants