-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend PHRMA Cancer: Adds _pct_share
cols
#3584
Merged
benhammondmusic
merged 10 commits into
SatcherInstitute:main
from
benhammondmusic:phrma-brfss-pct-share
Aug 23, 2024
Merged
Backend PHRMA Cancer: Adds _pct_share
cols
#3584
benhammondmusic
merged 10 commits into
SatcherInstitute:main
from
benhammondmusic:phrma-brfss-pct-share
Aug 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for health-equity-tracker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ity-tracker into phrma-brfss-pct-share
eriwarr
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
kccrtv
pushed a commit
to kccrtv/health-equity-tracker
that referenced
this pull request
Aug 27, 2024
# Description and Motivation <!--- bulleted, high level items. use keywords (eg "closes SatcherInstitute#144" or "fixes #4323") --> - part of SatcherInstitute#3579 - extricate `build_bq_col_types()` in util function which scans df and automatically gets the metric cols based on suffixes - calcs pct_shares with or without "unknowns" based on the demographic breakdown and what's reflected in the source data - updates golden data with new cols ## Has this been tested? How? - tests passing ## Types of changes (leave all that apply) - New content or feature ## New frontend preview link is below in the Netlify comment 😎 --------- Co-authored-by: Eric M Warren II <eric.m.warren1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
build_bq_col_types()
in util function which scans df and automatically gets the metric cols based on suffixesHas this been tested? How?
Types of changes
(leave all that apply)
New frontend preview link is below in the Netlify comment 😎