-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
how to use the data policy tab #3572
Conversation
…AQs tabs, and accordion redesign (SatcherInstitute#3571) this PR replaces the Taviraj H1 font with DM Sans for consistency across the platform and ensures the submenu is displayed on all breakpoints. it adds content to the Current Efforts and Reform Opportunities tabs, as well as the FAQs tab. additionally, the FAQ accordions have been redesigned for a more user-friendly experience. tests passing <img width="1425" alt="Screenshot 2024-08-20 at 2 01 00 PM" src="https://github.com/user-attachments/assets/6261faf9-15d3-429d-ba14-c41728a2aa8b"> <img width="1425" alt="Screenshot 2024-08-20 at 2 00 24 PM" src="https://github.com/user-attachments/assets/e15e3bb5-f471-4e18-bade-ca9f670ce826"> <img width="1425" alt="Screenshot 2024-08-20 at 2 00 30 PM" src="https://github.com/user-attachments/assets/3f7a01ce-fe4e-49cd-b822-2f67e2463aee"> - New content or feature - Refactor / chore add `/policy` at the end of the URL to preview --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ben Hammond <benjamin.hammond@gmail.com>
✅ Deploy Preview for health-equity-tracker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks so good! Just made a few suggestions.
frontend/src/pages/Policy/policySections/HowToUseTheDataTab.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks awesome and will be really helpful. I've done an initial pass on updating the options to better reflect our data, but will probably have more comments once i know if this represents just the gun violence topics or the tracker more generally
frontend/src/pages/Policy/policyContent/HowToUseTheDataContent.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/Policy/policyContent/HowToUseTheDataContent.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/Policy/policyContent/HowToUseTheDataContent.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/Policy/policyContent/HowToUseTheDataContent.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/Policy/policyContent/HowToUseTheDataContent.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/Policy/policyContent/HowToUseTheDataContent.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/Policy/policyContent/HowToUseTheDataContent.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/Policy/policyContent/HowToUseTheDataContent.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome
# Description and Motivation This PR focuses on refining the “How To Use the Data” tab by adding custom dynamic charts to improve data visualization. A Lightbox component was added per original mockup, but instead uses dynamic custom charts and maps. Arbitrary class names from Webflow mockup have been cleaned up for clearer code structure. Additionally, the Lightbox component and related graphics have been removed as part of this refactor. ## Has this been tested? How? tests passing ## Screenshots (if appropriate) <img width="1305" alt="Screenshot 2024-08-21 at 4 33 13 PM" src="https://github.com/user-attachments/assets/df75bd7d-ad0d-4fd2-b1db-2f9028403df8"> <img width="1305" alt="Screenshot 2024-08-21 at 4 33 04 PM" src="https://github.com/user-attachments/assets/60bade59-4c45-4e79-a279-dcbb1223746f"> <img width="1305" alt="Screenshot 2024-08-21 at 4 34 15 PM" src="https://github.com/user-attachments/assets/216d1c87-4fc8-457d-9e48-679164100254"> ## Types of changes - New content or feature - Refactor / chore ## New frontend preview link is below in the Netlify comment 😎 add `/policy` at the end of the URL to preview https://deploy-preview-3572--health-equity-tracker.netlify.app/policy/gun-violence/how-to-use-the-data --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ben Hammond <benjamin.hammond@gmail.com>
Description and Motivation
This PR focuses on refining the “How To Use the Data” tab by adding custom dynamic charts to improve data visualization. A Lightbox component was added per original mockup, but instead uses dynamic custom charts and maps. Arbitrary class names from Webflow mockup have been cleaned up for clearer code structure. Additionally, the Lightbox component and related graphics have been removed as part of this refactor.
Has this been tested? How?
tests passing
Screenshots (if appropriate)
Types of changes
New frontend preview link is below in the Netlify comment 😎
add
/policy
at the end of the URL to previewhttps://deploy-preview-3572--health-equity-tracker.netlify.app/policy/gun-violence/how-to-use-the-data