Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to use the data policy tab #3572

Merged
merged 19 commits into from
Aug 22, 2024
Merged

Conversation

kccrtv
Copy link
Collaborator

@kccrtv kccrtv commented Aug 20, 2024

Description and Motivation

This PR focuses on refining the “How To Use the Data” tab by adding custom dynamic charts to improve data visualization. A Lightbox component was added per original mockup, but instead uses dynamic custom charts and maps. Arbitrary class names from Webflow mockup have been cleaned up for clearer code structure. Additionally, the Lightbox component and related graphics have been removed as part of this refactor.

Has this been tested? How?

tests passing

Screenshots (if appropriate)

Screenshot 2024-08-21 at 4 33 13 PM Screenshot 2024-08-21 at 4 33 04 PM Screenshot 2024-08-21 at 4 34 15 PM

Types of changes

  • New content or feature
  • Refactor / chore

New frontend preview link is below in the Netlify comment 😎

add /policy at the end of the URL to preview

https://deploy-preview-3572--health-equity-tracker.netlify.app/policy/gun-violence/how-to-use-the-data

kccrtv and others added 10 commits August 20, 2024 14:40
…AQs tabs, and accordion redesign (SatcherInstitute#3571)

this PR replaces the Taviraj H1 font with DM Sans for consistency across
the platform and ensures the submenu is displayed on all breakpoints. it
adds content to the Current Efforts and Reform Opportunities tabs, as
well as the FAQs tab. additionally, the FAQ accordions have been
redesigned for a more user-friendly experience.

tests passing

<img width="1425" alt="Screenshot 2024-08-20 at 2 01 00 PM"
src="https://github.com/user-attachments/assets/6261faf9-15d3-429d-ba14-c41728a2aa8b">
<img width="1425" alt="Screenshot 2024-08-20 at 2 00 24 PM"
src="https://github.com/user-attachments/assets/e15e3bb5-f471-4e18-bade-ca9f670ce826">
<img width="1425" alt="Screenshot 2024-08-20 at 2 00 30 PM"
src="https://github.com/user-attachments/assets/3f7a01ce-fe4e-49cd-b822-2f67e2463aee">

- New content or feature
- Refactor / chore

add `/policy` at the end of the URL to preview

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ben Hammond <benjamin.hammond@gmail.com>
Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for health-equity-tracker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2827ca8
🔍 Latest deploy log https://app.netlify.com/sites/health-equity-tracker/deploys/66c78d5e3fa8d50008470c90
😎 Deploy Preview https://deploy-preview-3572--health-equity-tracker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kccrtv kccrtv changed the title How to use the data how to use the data policy tab Aug 21, 2024
@kccrtv kccrtv marked this pull request as ready for review August 21, 2024 22:34
Copy link
Collaborator

@eriwarr eriwarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so good! Just made a few suggestions.

frontend/src/reports/CustomUnknownMap.tsx Outdated Show resolved Hide resolved
frontend/src/reports/CustomChoroplethMap.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@benhammondmusic benhammondmusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks awesome and will be really helpful. I've done an initial pass on updating the options to better reflect our data, but will probably have more comments once i know if this represents just the gun violence topics or the tracker more generally

Copy link
Collaborator

@benhammondmusic benhammondmusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@kccrtv kccrtv dismissed eriwarr’s stale review August 22, 2024 20:40

requested changes implemented!

@kccrtv kccrtv merged commit e08f18a into SatcherInstitute:main Aug 22, 2024
10 checks passed
@kccrtv kccrtv deleted the how-to-use-the-data branch August 22, 2024 20:41
kccrtv added a commit to kccrtv/health-equity-tracker that referenced this pull request Aug 27, 2024
# Description and Motivation
This PR focuses on refining the “How To Use the Data” tab by adding
custom dynamic charts to improve data visualization. A Lightbox
component was added per original mockup, but instead uses dynamic custom
charts and maps. Arbitrary class names from Webflow mockup have been
cleaned up for clearer code structure. Additionally, the Lightbox
component and related graphics have been removed as part of this
refactor.

## Has this been tested? How?
tests passing

## Screenshots (if appropriate)
<img width="1305" alt="Screenshot 2024-08-21 at 4 33 13 PM"
src="https://github.com/user-attachments/assets/df75bd7d-ad0d-4fd2-b1db-2f9028403df8">
<img width="1305" alt="Screenshot 2024-08-21 at 4 33 04 PM"
src="https://github.com/user-attachments/assets/60bade59-4c45-4e79-a279-dcbb1223746f">
<img width="1305" alt="Screenshot 2024-08-21 at 4 34 15 PM"
src="https://github.com/user-attachments/assets/216d1c87-4fc8-457d-9e48-679164100254">

## Types of changes
- New content or feature
- Refactor / chore

## New frontend preview link is below in the Netlify comment 😎
add `/policy` at the end of the URL to preview


https://deploy-preview-3572--health-equity-tracker.netlify.app/policy/gun-violence/how-to-use-the-data

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ben Hammond <benjamin.hammond@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants