Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor wisqars loading function #3533

Merged
merged 21 commits into from
Aug 6, 2024

Conversation

benhammondmusic
Copy link
Collaborator

@benhammondmusic benhammondmusic commented Aug 5, 2024

Description and Motivation

  • closes Should we abstract def load_wisqars_df_from_data_dir #3317
  • creates new util function to handle the actual loading of the csv
  • renames per data source processing functions; I found it confusing that each source had it's own version of load_ function but they each did their own things
  • adds types to refactored functions
  • fixed issue with data file naming once it was caught by the new function usage
  • adds script to run mypy locally with the same settings that will run on CICD. just run ./scripts/run_mpyp.sh from the terminal and it'll type checked any changed python files on your local branch

Has this been tested? How?

  • tests still pass

Types of changes

(leave all that apply)

  • Refactor / chore

New frontend preview link is below in the Netlify comment 😎

@benhammondmusic benhammondmusic self-assigned this Aug 5, 2024
@benhammondmusic benhammondmusic marked this pull request as ready for review August 6, 2024 14:24
@benhammondmusic benhammondmusic merged commit 3aa0a7a into SatcherInstitute:main Aug 6, 2024
8 checks passed
@benhammondmusic benhammondmusic deleted the load-wisqars branch August 6, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we abstract def load_wisqars_df_from_data_dir
2 participants