Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rpath option #84

Closed
wants to merge 1 commit into from
Closed

add rpath option #84

wants to merge 1 commit into from

Conversation

jeffhammond
Copy link
Contributor

This adds -Wl,-rpath -Wl,$libdir to the wrapper LDFLAGS so that one need not set LD_LIBRARY_PATH for SOS libraries in order to use them.

This is convenient if one intends to have multiple installs of SOS and rely upon the uniqueness of their respective wrappers to get the right shared library.

This does not rpath libfabric. I think I can add that later, as an option to --enable-wrapper-rpath.

@jdinan
Copy link
Member

jdinan commented Dec 23, 2015

Thanks for looking into this. I'd like to look at the problem a little more before we settle on a solution. I'm not sure whether the right place to fix it is in configure or in the wrappers. If we do it in configure, I'd like it to be automatic. I think the wrappers are also cribbed from Open MPI; I'd like to see how they solve this and whether it's a solution we can adopt.

@hppritcha
Copy link
Collaborator

👍

This configury change makes me much happier when trying to use sandia shmem on cray. Now I don't need to fiddle with LD_LIBRARY_PATH to avoid picking up the cray sma library. It also avoids the having libfabric appear linked in twice (first by the sma dependency on libfabric), and then the extralibs having libfabric in it.

@jdinan
Copy link
Member

jdinan commented Jan 15, 2016

Is there a good reason for this to be optional?

@jeffhammond
Copy link
Contributor Author

@jdinan rust-lang/rust#5219 appears to contain some arguments...

@jdinan jdinan mentioned this pull request Jan 15, 2016
@jdinan
Copy link
Member

jdinan commented Jan 15, 2016

Superseded by #101

@jdinan jdinan closed this Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants