Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absolute paths to built-in scripts in settings.config #460

Open
SanderVocke opened this issue Oct 19, 2024 · 5 comments
Open

Absolute paths to built-in scripts in settings.config #460

SanderVocke opened this issue Oct 19, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@SanderVocke
Copy link
Owner

The LUA script settings structure stored into settings.config stores absolute paths. This will cause problems if the ShoopDaLoop installation moves or its internal structure changes. Instead, for built-in scripts, the paths should contain a placeholder (e.g. "@builtins"), or additional field.
@SanderVocke SanderVocke added the bug Something isn't working label Oct 19, 2024
@SanderVocke
Copy link
Owner Author

@openhands-agent please try to solve.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2024

OpenHands started fixing the issue! You can monitor the progress here.

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2024

OpenHands started fixing the issue! You can monitor the progress here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

OpenHands started fixing the issue! You can monitor the progress here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

An attempt was made to automatically fix this issue, but it was unsuccessful. A branch named 'openhands-fix-issue-460' has been created with the attempted changes. You can view the branch here. Manual intervention may be required.

SanderVocke pushed a commit that referenced this issue Dec 2, 2024
@openhands-agent
Fix issue #460: Absolute paths to built-in scripts in settings.config
29b4b8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SanderVocke