Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhoneNumber to capability Token and the queue size #82

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Conversation

SamuelMwangiW
Copy link
Owner

No description provided.

@what-the-diff
Copy link

what-the-diff bot commented Sep 5, 2023

PR Summary

  • Expanded Customization in Token Requests
    The update in src/Saloon/Requests/Voice/CapabilityTokenRequest.php allows us to incorporate more personalized information - specifically, 'phoneNumber'. This means our system can now handle capability tokens associated with specific phone numbers.

  • Enhanced Object Construction in ValueObject CapabilityToken
    The CapabilityToken updates in src/ValueObjects/CapabilityToken.php add a new argument to existing methods for a more thorough object construction. This change allows us to include phone numbers in our tokens - expanding the variety of information tokens can hold.

  • Queue Size Inclusion in VoiceCall Response
    With the addition of the queueSize property in src/ValueObjects/VoiceCAllResponse.php, our system can now obtain the size of the queue during voice calls. This will give us an overview of how many requests are waiting at any given time, enhancing our capacity to manage call traffic.

@SamuelMwangiW SamuelMwangiW changed the title y PhoneNumber to capability Token and the queue size Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #82 (004e911) into main (fe44689) will decrease coverage by 0.04%.
The diff coverage is 83.33%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #82      +/-   ##
============================================
- Coverage     88.70%   88.66%   -0.04%     
  Complexity      453      453              
============================================
  Files            83       83              
  Lines          1665     1668       +3     
============================================
+ Hits           1477     1479       +2     
- Misses          188      189       +1     

@SamuelMwangiW SamuelMwangiW merged commit c096394 into main Sep 5, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant