Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Bundles #78

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Data Bundles #78

merged 2 commits into from
Aug 2, 2023

Conversation

SamuelMwangiW
Copy link
Owner

  • Voice test papercuts and Initialize Mobile data
  • Added Data bundles

@what-the-diff
Copy link

what-the-diff bot commented Aug 2, 2023

PR Summary

  • New File Addition: Managing Mobile Data
    A new file has been added which introduces capabilities to organize and handle functions related to mobile data.

  • Enhancements in Africastalking Methods
    The existing Africastalking file has been fine-tuned. It has two freshly developed methods that contribute to enhancing bundles and mobile data operations.

  • Inclusion of New Enum Classes
    We have included two additional enum classes dedicated to enhance sorting and validation processes within our bundle operations.

  • Minor File Adjustments
    A couple of files named Service and Status under the Enum directory have been slightly modified to include new URL entries and enumeration values respectively. This will enhance our data services, status tracking and queuing functionalities.

  • Typo Rectification
    In the VoiceEventRequest file, we've identified and corrected a typo in one of the field names.

  • New Class for Mobile Data Service Requests
    A class specifically for making requests to the mobile data service has been introduced, which will streamline the process of requesting mobile data services.

  • Addition of Files for Mobile Data Functionality
    Added multiple new files to assist with operations related to mobile data. These are essentially predefined objects, dedicated to maintaining and handling responses linked to our mobile data services.

  • Test File Modifications
    Our test files have been updated to include new cases such as voice events with zero duration and missing details. This will ensure greater robustness in our testing procedures.

  • Fixture Additions for Mobile Data Requests
    In order to facilitate better testing of mobile data requests, new fixtures have been added in the mentioned directory.

  • New Tests for Mobile Data Functionality
    To ensure our new mobile data functions perform as expected, a range of new tests has been added in the associated test file.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #78 (e99cc6f) into main (325ce64) will increase coverage by 0.39%.
Report is 1 commits behind head on main.
The diff coverage is 92.15%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #78      +/-   ##
============================================
+ Coverage     88.30%   88.70%   +0.39%     
- Complexity      429      453      +24     
============================================
  Files            78       83       +5     
  Lines          1565     1664      +99     
============================================
+ Hits           1382     1476      +94     
- Misses          183      188       +5     

@SamuelMwangiW SamuelMwangiW merged commit 9a2aa89 into main Aug 2, 2023
11 checks passed
@SamuelMwangiW SamuelMwangiW deleted the data-bundles branch August 2, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant