Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Voice Notification #106

Closed
wants to merge 1 commit into from
Closed

Add Voice Notification #106

wants to merge 1 commit into from

Conversation

SamuelMwangiW
Copy link
Owner

No description provided.

Copy link

what-the-diff bot commented Aug 5, 2024

PR Summary

  • Update on class usage and deprecation
    The AfricastalkingChannel class is renamed as AfricastalkingSmsChannel within several files. This reflects the new naming standard throughout the project. Furthermore, the original AfricastalkingChannel class is now marked as deprecated.

  • Introduction of New File
    A new file src/Notifications/AfricastalkingSmsChannel.php has been introduced as part of this process.

  • Improve Code Consistency
    The AfricastalkingChannel is replaced by AfricastalkingSmsChannel in the via method used within some test files. This brings these parts of the codebase into line with the updated naming conventions.

  • Enhanced Code Readability
    The toAfricastalking method has had type hinting added for the $notifiable parameter, which in turn, improves the readability and understanding of the code.

  • Updated Test Cases
    The test cases within the Unit/Notifications/AfricastalkingChannelTest.php have been updated to reflect the change from AfricastalkingChannel to AfricastalkingSmsChannel.

@SamuelMwangiW SamuelMwangiW deleted the voice-notification branch August 5, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant