Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing nc_tools tests #113

Merged
merged 3 commits into from
Dec 21, 2024
Merged

Fix failing nc_tools tests #113

merged 3 commits into from
Dec 21, 2024

Conversation

douglatornell
Copy link
Member

@douglatornell douglatornell commented Dec 21, 2024 •
edited
Loading

Summary

This pull request primarily focuses on refining unit tests for the nc_tools module. Changes standardize output formats and behavior of test functions to enhance readability and maintain consistency.

Main changes

  • Standardization of test outputs:
    • Updated expected outputs in test functions for better clarity, including replacing single-line string assertions with split lines.
    • Modified test cases for output comparison to use consistent formats (e.g., aligning expected dimension and variable representations).
  • Improved maintainability:
    • Enhanced structure and readability of test functions with clear block separation (e.g., variable creation, assertion checks).
    • Adjusted mock function returns and associated tests to maintain or add clarity (URL cases).
  • No modifications to library functionality:
    • The implementation code remains unchanged in this PR; all changes are confined to the test files.

@douglatornell
Improve test assertions for nc_tools output verification
9c45437 
Revised test cases to compare against expected lists for clarity and consistency.
This ensures all output lines are verified without relying on specific indices
or partial string matches. Updated function names and fixed minor formatting
issues where applicable.
@douglatornell
Revert test URL change from GitHub to Bitbucket
27f26e3 
Replaced GitHub links with Bitbucket links in test cases because the function
under test is for Bitbucket URLs. The test URLs were changed to github.com in an
overzealous global search/replace operation.
@douglatornell
Fix typo in docstring
5c2a7d5
@douglatornell douglatornell added the bug Something isn't working label Dec 21, 2024
@douglatornell douglatornell added this to the v24.1 milestone Dec 21, 2024
@douglatornell douglatornell changed the title Fix failing tests Fix failing nc_tools tests Dec 21, 2024
@douglatornell douglatornell merged commit 975a0b0 into main Dec 21, 2024
4 checks passed
@douglatornell douglatornell deleted the fix-failing-tests branch December 21, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@douglatornell douglatornell

Labels
bug Something isn't working
Projects
None yet
Milestone
v24.1
Development

Successfully merging this pull request may close these issues.
1 participant
@douglatornell