Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting back to js to prepare for ES6 instead of TypeScript. #354

Merged
merged 1 commit into from
Jul 21, 2015

Conversation

jbest84
Copy link
Member

@jbest84 jbest84 commented Jul 21, 2015

Backing out of Typescript for now, due to microsoft/TypeScript#2719

jbest84 added a commit that referenced this pull request Jul 21, 2015
Reverting back to js to prepare for ES6 instead of TypeScript.
@jbest84 jbest84 merged commit 044fe74 into develop Jul 21, 2015
@RyanFarley
Copy link

👍 x 💯

@jbest84
Copy link
Member Author

jbest84 commented Jul 21, 2015

@RyanFarley Not a TS fan?

@RyanFarley
Copy link

lol no :)

@jbest84
Copy link
Member Author

jbest84 commented Jul 21, 2015

Due to the issue above, and the fact that TypeScript does not support stamping in an AMD module ID, we are backing off (I had a branch dedicated to TypeScript modules, it was not yet merged). Are you just against TypeScript, or transpiling in general? We are considering pulling in my topic-babel branch and going ES6 to stay with the standard.

@jbest84
Copy link
Member Author

jbest84 commented Jul 21, 2015

@CHenrie argos-sdk and argos-saleslogix have both been reverted from TS and types stripped away.

@RyanFarley
Copy link

Not exactly against transpiling, just never been a fan of typescript, but that's mainly because it feels less javascripty and I like javascript to feel javascripty - but to be honest I suppose I've never really given it a fair try. I'd be all for going es6 with babel.

@jbest84
Copy link
Member Author

jbest84 commented Jul 21, 2015

Typescript is nice, there is no doubt about that. Hopefully the TC39 committee will get something going in this area (Brendan Eich appears to be a fan of TS). After ES6 (Ecmascript 2015) they plan on doing a yearly summer release, or that was the plan. So hopefully we see ES7/ES8 soon! We just need Apple to get on board and start doing rolling releases for Safari.

@rjledger
Copy link

Jumping in here too.. Glad to see you dropped the typescript path - not a fan either. Agree w/Ryan's comments * 1000% ;-)

@jbest84 jbest84 deleted the topic-remove-ts branch July 23, 2015 18:07
jbest84 pushed a commit that referenced this pull request Jun 19, 2017
…os-saleslogix:develop to develop

* commit '21adfb40031159a4f7ea2c1d3328f3ea9627521e':
  INFORCRM-16623: Added formatting file for es-ES
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants