Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Robot] Add Requirement Test and namespace fixes for running tests in 2gp org #36

Merged
merged 6 commits into from
Mar 12, 2021
Merged

[Robot] Add Requirement Test and namespace fixes for running tests in 2gp org #36

merged 6 commits into from
Mar 12, 2021

Conversation

gaganpsandhu
Copy link
Contributor

WI: W-8990513

Critical Changes

Changes

Issues Closed

New Metadata

Deleted Metadata

Definition of Done

Refer to Definition of Done to see any additional details for the items below:

  • Any net new LWC work has JEST test coverage 50% or above
  • Default Sa11y tests pass for all LWC components
  • 🔒 Secure both Front-end (LWC) & back-end (Apex) as necessary
  • 🔑 Grant users access in Permission Sets (Object, Field, Apex Class) as necessary
  • Link the pull request and work item by PR comment and Chatter post respectively, e.g. GUS: W-0000000: Work Name
  • Make sure that ACs are updated (if any gaps)
  • All acceptance criteria have been met
    • Developer
    • Code Reviewer
  • Pull Request contains draft release notes
  • Labels, help text, and customer facing messages are reviewed by Docs
  • QE story level testing completed

@gaganpsandhu gaganpsandhu requested a review from a team as a code owner March 10, 2021 23:44
@gaganpsandhu gaganpsandhu requested a review from djun1209 March 10, 2021 23:45
@gaganpsandhu gaganpsandhu added the needs RE review 🔒 This Pull Request still needs a RE review. label Mar 10, 2021
@gaganpsandhu gaganpsandhu requested a review from jstvz March 11, 2021 00:08
@gaganpsandhu gaganpsandhu removed the needs RE review 🔒 This Pull Request still needs a RE review. label Mar 11, 2021
@gaganpsandhu gaganpsandhu merged commit 8c2bc0f into master Mar 12, 2021
@gaganpsandhu gaganpsandhu deleted the feature/robot_requirement branch March 12, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstvz jstvz jstvz approved these changes

@djun1209 djun1209 Awaiting requested review from djun1209

Assignees
No one assigned
Labels
robot test 🤖
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaganpsandhu @jstvz