Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get tests passing #45

Merged
merged 5 commits into from
Aug 28, 2023
Merged

Get tests passing #45

merged 5 commits into from
Aug 28, 2023

Conversation

reidmorrison
Copy link
Contributor

@reidmorrison reidmorrison commented Aug 28, 2023 •
edited
Loading

Get the tests passing on Github actions with Ruby 2.7 and above

@reidmorrison reidmorrison changed the title Update tcr.yml Get tests passing Aug 28, 2023
sionide21
sionide21 requested changes Aug 28, 2023
View reviewed changes
Copy link
Member

@sionide21 sionide21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One requested change, everything else looks good!

.github/workflows/tcr.yml Show resolved Hide resolved
@sionide21 sionide21 requested review from robforman and a team as code owners August 28, 2023 22:01
@sionide21 sionide21 merged commit 21bfb7a into master Aug 28, 2023
4 checks passed
@sionide21 sionide21 deleted the rm-test branch August 28, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sionide21 sionide21 sionide21 approved these changes

@jakekaad-salesloft jakekaad-salesloft jakekaad-salesloft approved these changes

@robforman robforman Awaiting requested review from robforman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reidmorrison @sionide21 @jakekaad-salesloft