Add newer ruby versions to CI #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In Ruby 3.2 the method 'exists?' was deprecated, so it was necessary to replace it for its equilavent 'exist?' to support it.
Nicolasvb23
changed the title
|
Thanks for your PR @Nicolasvb23! Amazingly, two PRs came in at almost the exact same time to fix this issue. I'm closing this one as #43 was merged last night. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Ruby 3.1, 3.2 were added to the matrix of the CI.
Although the spec suite was already passing in Ruby 3.1, to add the support for Ruby 3.2 was necessary to replace with
exist?the methodexists?which was totally removed since Ruby 3.2.Extra comment
To continue having the Ruby 2.2 version in the CI, it was necessary to run it in other ubuntu version due to some problems while trying to install
bundler.Further information about this can be found here: