-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ruby3 support #38
Conversation
@kvokka we have issues with this part where class Socket
class << self
alias_method :real_tcp, :tcp
def tcp(host, port, *socket_opts)
if TCR.configuration.hook_tcp_ports.include?(port)
TCR::RecordableTCPSocket.new(host, port, TCR.cassette)
else
real_tcp(host, port, *socket_opts)
end
end
end
end In Ruby 3, that needs to be Btw, it seems that the owner of this repository @robforman is not active on GitHub anymore since 2018. Maybe |
@mgruner I'm not as active. Want to be a collaborator on the project? |
@robforman thank you for your proposal, I needed a moment to reflect on it. Can I support you in getting If that's fine for you, feel free to add me here and possibly on rubygems.org (username mrtngrnr). Thanks! |
**socket_opts still gives errors for me when using ldap bind.
|
Fixed in #41 |
Removed EOL Ruby versions and added actual instead
Keep in mind, that the most recent versions require TLS in SMTP requests, which required to update a couple of requests.
Made specs green again
Added Ruby 3 Ractor support (technically lib/tcr/recordable_tcp_socket.rb#13 was the only thing which i initially needed)