Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy fixing #423

Merged
merged 6 commits into from
Jan 1, 2025
Merged

Mypy fixing #423

merged 6 commits into from
Jan 1, 2025

Conversation

BDadmehr0
Copy link
Member

No description provided.

@BDadmehr0
Copy link
Member Author

BDadmehr0 commented Dec 30, 2024

Before :

➜  config git:(main) mypy .

module/validation.py:3: error: Cannot find implementation or library stub for module named "utils"  [import-not-found]
layout/type.validate.py:8: error: Cannot find implementation or library stub for module named "utils"  [import-not-found]
layout/type.validate.py:9: error: Cannot find implementation or library stub for module named "validation"  [import-not-found]
layout/attribute/value.validate.py:8: error: Cannot find implementation or library stub for module named "utils"  [import-not-found]
layout/attribute/value.validate.py:9: error: Cannot find implementation or library stub for module named "validation"  [import-not-found]
layout/attribute/type.validate.py:8: error: Cannot find implementation or library stub for module named "utils"  [import-not-found]
layout/attribute/type.validate.py:9: error: Cannot find implementation or library stub for module named "validation"  [import-not-found]
layout/attribute/style/value.validate.py:8: error: Cannot find implementation or library stub for module named "utils"  [import-not-found]
layout/attribute/style/value.validate.py:9: error: Cannot find implementation or library stub for module named "validation"  [import-not-found]
layout/attribute/style/type.validate.py:8: error: Cannot find implementation or library stub for module named "utils"  [import-not-found]
layout/attribute/style/type.validate.py:9: error: Cannot find implementation or library stub for module named "validation"  [import-not-found]
layout/attribute/style/state.validate.py:8: error: Cannot find implementation or library stub for module named "utils"  [import-not-found]
layout/attribute/style/state.validate.py:9: error: Cannot find implementation or library stub for module named "validation"  [import-not-found]
layout/attribute/style/global_value.validate.py:8: error: Cannot find implementation or library stub for module named "utils"  [import-not-found]
layout/attribute/style/global_value.validate.py:8: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
layout/attribute/style/global_value.validate.py:9: error: Cannot find implementation or library stub for module named "validation"  [import-not-found]
sync.py:228: error: Unsupported operand types for + ("str" and "None")  [operator]
sync.py:228: note: Right operand is of type "Any | None"
sync.py:263: error: Unsupported operand types for + ("str" and "None")  [operator]
sync.py:263: note: Right operand is of type "Any | None"
admin/app.py:67: error: Incompatible return value type (got "set[Any]", expected "list[str]")  [return-value]
admin/app.py:186: error: Incompatible return value type (got "Response", expected "str")  [return-value]
admin/app.py:223: error: Incompatible return value type (got "Response", expected "str")  [return-value]
admin/app.py:231: error: Incompatible return value type (got "Response", expected "str")  [return-value]
admin/app.py:244: error: Incompatible return value type (got "Response", expected "str")  [return-value]
admin/app.py:250: error: Incompatible return value type (got "Response", expected "str")  [return-value]
admin/app.py:258: error: Incompatible return value type (got "Response", expected "str")  [return-value]
admin/app.py:263: error: Incompatible return value type (got "Response", expected "str")  [return-value]
admin/app.py:295: error: Incompatible return value type (got "Response", expected "str")  [return-value]
Found 26 errors in 10 files (checked 18 source files)

After :

➜  config git:(mypy-fixing) mypy .   

Success: no issues found in 18 source files

@github-actions github-actions bot removed the scripts label Jan 1, 2025
@BaseMax BaseMax merged commit 040d543 into SalamLang:main Jan 1, 2025
12 of 14 checks passed
@BaseMax
Copy link
Member

BaseMax commented Jan 1, 2025

See error:
image

@BaseMax
Copy link
Member

BaseMax commented Jan 1, 2025

@BDadmehr0 Please check above

@BDadmehr0 BDadmehr0 deleted the mypy-fixing branch January 1, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants