Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify README file #125

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Modify README file #125

merged 3 commits into from
Oct 9, 2023

Conversation

Mikachu2333
Copy link
Collaborator

  1. Renformat Readme
  2. Add an example
  3. Clearly introduct range of each opinion

SalOne22
SalOne22 requested changes Oct 9, 2023
View reviewed changes
Copy link
Owner

@SalOne22 SalOne22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good, but section that auto generated by clap needs improvements. I also add this changes to source code, to match readme after this PR.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
SalOne22
SalOne22 approved these changes Oct 9, 2023
View reviewed changes
Copy link
Owner

@SalOne22 SalOne22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good

@SalOne22 SalOne22 merged commit 0c0a2b1 into SalOne22:main Oct 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SalOne22 SalOne22 SalOne22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mikachu2333 @SalOne22