[SAH-77]: Supplier Inventory Page #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| {newImages.map((image, index) => ( | ||
| <div key={`new-${index}`} className="relative group"> | ||
| <img | ||
| src={URL.createObjectURL(image)} |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 2 months ago
To fix the problem, we need to ensure that the uploaded image files are properly validated and sanitized before being used. One way to achieve this is by checking the file type and size before creating the object URL. Additionally, we can use a library like DOMPurify to sanitize any potentially unsafe content.
- Validate the file type and size before creating the object URL.
- Use
DOMPurifyto sanitize the object URL before using it as thesrcattribute of theimgelement. - Update the
handleImageUploadfunction to include these validations and sanitizations.
Suggested changeset
2
packages/features/Inventory/ProductForm.tsx
| @@ -6,2 +6,3 @@ | ||
| import { HiMinus, HiPlus } from 'react-icons/hi2'; | ||
| import DOMPurify from 'dompurify'; | ||
|
|
||
| @@ -53,3 +54,8 @@ | ||
| const filesArray = Array.from(e.target.files); | ||
| setNewImages((prevImages) => [...prevImages, ...filesArray]); | ||
| const validFiles = filesArray.filter(file => { | ||
| const isValidType = file.type.startsWith('image/'); | ||
| const isValidSize = file.size <= 5 * 1024 * 1024; // 5MB limit | ||
| return isValidType && isValidSize; | ||
| }); | ||
| setNewImages((prevImages) => [...prevImages, ...validFiles]); | ||
| } | ||
| @@ -165,3 +171,3 @@ | ||
| <img | ||
| src={URL.createObjectURL(image)} | ||
| src={DOMPurify.sanitize(URL.createObjectURL(image))} | ||
| alt={`New product image ${index + 1}`} |
packages/features/package.json
Outside changed files
| @@ -8,3 +8,4 @@ | ||
| "@sahil/configs": "*", | ||
| "ui": "*" | ||
| "ui": "*", | ||
| "dompurify": "^3.2.0" | ||
| } |
This fix introduces these dependencies
| Package | Version | Security advisories |
| dompurify (npm) | 3.2.0 | None |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.