Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve atomic.Value usages with interface types #59

Closed
wants to merge 2 commits into from
Closed

resolve atomic.Value usages with interface types #59

wants to merge 2 commits into from

Conversation

wwqgtxx
Copy link
Contributor

@wwqgtxx wwqgtxx commented Mar 13, 2024

resolve: #58

Billyzou0741326
Billyzou0741326 approved these changes Mar 13, 2024
View reviewed changes
Copy link

@Billyzou0741326 Billyzou0741326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this by pointing my local sing-box build to this commit:

go get github.com/sagernet/sing@e6ac717b929c2a3a7e1dd5c984e7b690e3502c82

Confirmed it didn't crash (yet).

I think it does indeed resolve #59

@nekohasekai nekohasekai deleted the wwqgtxx-patch-1 branch March 13, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Billyzou0741326 Billyzou0741326 Billyzou0741326 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic: sync/atomic: store of inconsistently typed value into Value
3 participants
@wwqgtxx @Billyzou0741326 @nekohasekai