Trojan fallback: support alpn address #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not get alpn in fallbackConnection? |
|
Yes I tried, but the conn is over wrapped and alpn cannot be fetched |
|
Also, always rebase instead of merging new changes. |
Use common.Cast |
|
I'll fix all of this and submit a new pr. Thank you |
nekohasekai
requested changes
Aug 25, 2022
Keep force commit here is just enough. |
nekohasekai
reviewed
Aug 25, 2022
nekohasekai
requested changes
Aug 25, 2022
inbound/trojan.go
Outdated
| inbound.fallbackAddr = options.Fallback.Build() | ||
| fallbackAddrs := make(map[string]M.Socksaddr) | ||
| for _, fallback := range options.Fallbacks { | ||
| if fallback.Server != "" { |
There was a problem hiding this comment.
If empty, it is better to return error.
|
All done. Thanks for your patient guiding! I'm new in golang and really learn a lot. |
|
pushed by mistake :( |
nekohasekai
pushed a commit
that referenced
this pull request
Aug 25, 2022
nekohasekai
pushed a commit
that referenced
this pull request
Aug 25, 2022
|
It appears that you cannot be included as a contributor in GitHub because you are using an invalid email. |
H1JK
pushed a commit
to H1JK/sing-box
that referenced
this pull request
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.