Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline friendly request/response #22

Closed
bjouhier opened this issue Nov 8, 2014 · 0 comments
Closed

Pipeline friendly request/response #22

bjouhier opened this issue Nov 8, 2014 · 0 comments

Comments

@bjouhier
Copy link
Member

bjouhier commented Nov 8, 2014

The request/response API that ez-streams inherited from streamline-streams does not play very well with the pipeline. Two problems (at least):

  • serverResponse is not exactly a writer because encoding is passed in each write call, instead of being configured in the writer. The end method cannot be aligned on the writer API because it is synchronous (so exception handling is out of bounds).
  • Applying pipeline operations to a request/response does not yield another request/response. Instead, it yields a reader/writer and all the extra request/response API (headers) is lost. For example, serverRequest.map(someMapper).url does not work.
@bjouhier bjouhier changed the title add readable.reader and writable.writer to node wrappers Pipeline friendly request/response Nov 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant