fix: address broken internal git hooks #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we upgraded husky without addressing the introduced breaking changes, making it possible to write commit messages which semantic-release would not recognise. - Update husky to v8.x - Address the breaking changes between v4.x and v8.x see #55
Including updating these dependencies to their latest versions: - @commitlint/cli to v17.6.1 - @commitlint/config-conventional to v17.6.1 - @semantic-release/changelog to v6.0.3 - @semantic-release/git to v10.0.1
DipperTheDan
approved these changes
May 4, 2023
nineteen88
approved these changes
May 5, 2023
|
Interesting that they've moved the config into actual config files now. Much better in my opinion |
|
🎉 This PR is included in version 1.14.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
huskyto version 8.xhuskybreaking changes between versions 4.x to 8.x@commitlint/clifrom version 13.1.0 to 17.6.1@commitlint/config-conventionalfrom version 13.2.0 to 17.6.1@semantic-release/changelogfrom version 5.0.1 to 6.0.3@semantic-release/gitfrom version 9.0.0 to 10.0.1Current behaviour
git commit- since we accidentally upgradedhuskywithout addressing the introduced breaking changes (see PR chore(deps-dev): bump husky from 4.3.0 to 6.0.0 #55). This means its possible to write commit messages whichsemantic-releasewould not recognise.Checklist
Testing instructions
To check post-commit actions are being triggered correctly, when making a commit, check the following actions are completed after
git commit: