Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SWC-6545 pre-work - Upgrade Storybook + expose ability to enable StrictMode #711

Merged
merged 3 commits into from
Feb 16, 2024
Merged

SWC-6545 pre-work - Upgrade Storybook + expose ability to enable StrictMode #711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b34c32
SWC-6545 pre-work - Upgrade Storybook + Enable StrictMode
nickgros Feb 14, 2024
0884ff5
SWC-6545 pre-work - Replace deprecated storybook-addon-designs with @…
nickgros Feb 14, 2024
005d8e5
Disable StrictMode by default
nickgros Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/synapse-react-client/.storybook/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,16 @@ const config: StorybookConfig = {
'@storybook/addon-essentials',
'@storybook/addon-interactions',
{
name: '@storybook/addon-styling',
name: '@storybook/addon-themes',
options: {},
},
'storybook-addon-designs',
'@storybook/addon-designs',
],

framework: {
name: '@storybook/react-vite',
options: {
strictMode: false,
Copy link
Collaborator Author

@nickgros nickgros Feb 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered enabling StrictMode by default, but wasn't sure if that might cause problems with stories. Explicitly setting it to false here makes it easy to go in and change it locally when desired. In the future, we can decide to enable it globally.

builder: {
viteConfigPath: './.storybook/storybook-vite.config.ts',
},
Expand Down
2 changes: 1 addition & 1 deletion packages/synapse-react-client/.storybook/preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { MOCK_REPO_ORIGIN } from '../src/utils/functions/getEndpoint'
import isChromatic from 'chromatic/isChromatic'
import { faker } from '@faker-js/faker'
import { ThemeProvider } from '@mui/material'
import { withThemeFromJSXProvider } from '@storybook/addon-styling'
import { withThemeFromJSXProvider } from '@storybook/addon-themes'
import {
adKnowledgePortalPalette,
arkPortalPalette,
Expand Down
22 changes: 11 additions & 11 deletions packages/synapse-react-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,16 +142,17 @@
"@juggle/resize-observer": "^3.4.0",
"@open-draft/deferred-promise": "^2.1.0",
"@rollup/plugin-inject": "^4.0.4",
"@storybook/addon-actions": "^7.5.3",
"@storybook/addon-essentials": "^7.5.3",
"@storybook/addon-interactions": "^7.5.3",
"@storybook/addon-links": "^7.5.3",
"@storybook/addon-styling": "^1.3.7",
"@storybook/manager-api": "^7.5.3",
"@storybook/react": "^7.5.3",
"@storybook/react-vite": "^7.5.3",
"@storybook/addon-actions": "^7.6.15",
"@storybook/addon-designs": "^7.0.9",
"@storybook/addon-essentials": "^7.6.15",
"@storybook/addon-interactions": "^7.6.15",
"@storybook/addon-links": "^7.6.15",
"@storybook/addon-themes": "^7.6.15",
"@storybook/manager-api": "^7.6.15",
"@storybook/react": "^7.6.15",
"@storybook/react-vite": "^7.6.15",
"@storybook/testing-library": "^0.2.2",
"@storybook/theming": "^7.5.3",
"@storybook/theming": "^7.6.15",
"@svgr/plugin-jsx": "^8.0.1",
"@testing-library/dom": "^8.20.1",
"@testing-library/jest-dom": "^6.1.4",
Expand Down Expand Up @@ -225,8 +226,7 @@
"react-select-event": "^5.5.1",
"react-test-renderer": "^18.2.0",
"rollup-plugin-polyfill-node": "^0.10.2",
"storybook": "^7.5.3",
"storybook-addon-designs": "7.0.0-beta.2",
"storybook": "^7.6.15",
"stream-browserify": "^3.0.0",
"stream-http": "^3.2.0",
"timers-browserify": "^2.0.12",
Expand Down
Loading
Loading