Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SNOW-160] Remove scripting block and reduce scope of refresh #92

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

philerooski
Copy link
Collaborator

I set up schemachange locally and ensured that by removing the scripting block I was able to successfully deploy the changes here (on a clone).

To limit the amount of data that needs to be loaded in the unlikely event we need to rollback/replay these changes, I changed the data being deleted/reloaded from all data from November 2024 onward to only data from November and December 2024. The side effect here is that any data from January 2025 onward which has been loaded into the table before we've replayed the V2.25.* scripts won't have its version_history data backfilled.

@philerooski philerooski requested a review from a team as a code owner December 10, 2024 22:58
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM! It'll probably be pretty unlikely that we will replay these events.

That is one reason why I constantly struggle with having R scripts to store constant state of objects vs these V scripts that keep a history of actions that we did on objects.

@philerooski philerooski merged commit c0523e1 into dev Dec 10, 2024
4 checks passed
@philerooski philerooski deleted the snow-160-no-scripting branch December 10, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants