-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SNOW-151] Initialize dynamic table: accessrequirement_latest
#84
Conversation
synapse_data_warehouse/synapse/dynamic_tables/V2.22.0__accessrequirement_latest.sql
Outdated
Show resolved
Hide resolved
synapse_data_warehouse/synapse/dynamic_tables/V2.22.0__accessrequirement_latest.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Excellent work. Going to pre-approve it.
synapse_data_warehouse/synapse/dynamic_tables/V2.22.0__accessrequirement_latest.sql
Outdated
Show resolved
Hide resolved
synapse_data_warehouse/synapse/dynamic_tables/V2.22.0__accessrequirement_latest.sql
Outdated
Show resolved
Hide resolved
synapse_data_warehouse/synapse/dynamic_tables/V2.23.0__accessrequirement_latest.sql
Outdated
Show resolved
Hide resolved
synapse_data_warehouse/synapse/dynamic_tables/V2.23.0__accessrequirement_latest.sql
Outdated
Show resolved
Hide resolved
synapse_data_warehouse/synapse/dynamic_tables/V2.23.0__accessrequirement_latest.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philerooski / @jaymedina take a look at my most recent comment
synapse_data_warehouse/synapse/dynamic_tables/V2.23.0__accessrequirement_latest.sql
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 LGTM! I'll defer to @philerooski for final review
synapse_data_warehouse/synapse/dynamic_tables/V2.23.0__accessrequirement_latest.sql
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 LGTM!
problem
accessrequirementsnapshots
does not exist in Snowflake.solution
Add a V script to initialize
accessrequirement_latest
testing
There are 3,878 unique access requirement IDs stored in the snapshots table, meaning there should be 3,878 total rows in the deduplicated latest table. The reason being that each submission can only be in 1 state - CREATED, UPDATED, or DELETED:
We verify that the V script generates a table with that many rows:
We verify that the 3,878 unique IDs in the snapshots table matches the 3,878 unique IDs in the latest table:
We use a few IDs to manually verify that the latest state of each submission is reflected in the latest table:
Before

After

Before
After
