Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permission to execute procedure to GOVERNANCE #49

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

xschildw
Copy link
Contributor

@xschildw xschildw commented Jun 7, 2024

No description provided.

@xschildw xschildw requested a review from a team as a code owner June 7, 2024 16:15
@xschildw xschildw requested a review from thomasyu888 June 7, 2024 16:15
admin/grants.sql Outdated
@@ -327,6 +327,11 @@ GRANT SELECT ON FUTURE VIEWS IN DATABASE SYNAPSE_DATA_WAREHOUSE
TO ROLE GOVERNANCE;
GRANT SELECT ON FUTURE DYNAMIC TABLES IN DATABASE SYNAPSE_DATA_WAREHOUSE
TO ROLE GOVERNANCE;
GRANT EXECUTE ON ALL PROCEDURES IN DATABASE SYNAPSE_DATA_WAREHOUSE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xschildw Can you link off to the docs that specify what EXECUTE is granting here?

What I am finding is that https://docs.snowflake.com/en/user-guide/security-access-control-privileges doesn't define an EXECUTE privilege. I am seeing that the examples from https://docs.snowflake.com/en/sql-reference/sql/grant-privilege#roles are showing something like:
GRANT USAGE ON ALL PROCEDURES IN DATABASE SYNAPSE_DATA_WAREHOUSE TO ROLE GOVERNANCE;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I just went with what I remembered from SQL... Will fix.

Copy link

sonarqubecloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
32.2% Duplication on New Code

See analysis details on SonarCloud

@xschildw xschildw requested a review from BryanFauble June 7, 2024 18:09
Copy link
Contributor

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will need testing once deployed.

@thomasyu888 thomasyu888 merged commit 16a5cc1 into Sage-Bionetworks:dev Jun 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants