-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SNOW-80] Adds table and column comments for TEAMMEMBER_LATEST table #44
[SNOW-80] Adds table and column comments for TEAMMEMBER_LATEST table #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
synapse_data_warehouse/synapse/tables/V2.19.1__add_descriptions_to_teammember_latest.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, but the table name is incorrect NODE_LATEST
|
Thanks @thomasyu888, I had made the change but forgot to push the commit before requesting review 😅 |
🎉 All dependencies have been resolved ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 LGTM!
This PR adds table and column comments for the
TEAMMEMBER_LATEST
table. This work and the syntax used is based on #38.depends on #46