Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SNOW-80] Adds table and column comments for TEAMMEMBER_LATEST table #44

Merged
merged 2 commits into from
May 31, 2024

Conversation

BWMac
Copy link
Contributor

@BWMac BWMac commented May 30, 2024

This PR adds table and column comments for the TEAMMEMBER_LATEST table. This work and the syntax used is based on #38.

depends on #46

@BWMac BWMac marked this pull request as ready for review May 30, 2024 20:31
@BWMac BWMac requested a review from a team as a code owner May 30, 2024 20:31
Copy link
Contributor

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, but the table name is incorrect NODE_LATEST

@BWMac BWMac requested a review from thomasyu888 May 30, 2024 20:57
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@BWMac
Copy link
Contributor Author

BWMac commented May 30, 2024

Thanks @thomasyu888, I had made the change but forgot to push the commit before requesting review 😅

Copy link

dpulls bot commented May 31, 2024

🎉 All dependencies have been resolved !

Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM!

@thomasyu888 thomasyu888 merged commit 79f130c into dev May 31, 2024
3 checks passed
@thomasyu888 thomasyu888 deleted the bwmac/SNOW-80/teammember_latest_descriptions branch May 31, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants