Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify tasks #35

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Unify tasks #35

merged 4 commits into from
Apr 23, 2024

Conversation

thomasyu888
Copy link
Member

Problem
Some tasks weren't being triggered by the refresh task.

Solution
Push all tasks to be triggered after the refresh S3 task.

ALTER TASK TEAMSNAPSHOTS_TASK RESUME;
ALTER TASK VERIFICATIONSUBMISSIONSNAPSHOTS_TASK RESUME;
ALTER TASK USERGROUPSNAPSHOTS_TASK RESUME;
ALTER TASK refresh_synapse_warehouse_s3_stage_task RESUME;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any possible issues setting the s3 task to RESUME last? (I'm not too knowledgeable om this part of snowflake)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. Snowflake tasks are finicky. They have to start and resume in the opposite order. Take this mermaid diagram

flowchart  TD
    A --> B
Loading

To modify task B, I have to stop task A first, then task B. Then I have to resume task B then task A. At least last I checked, it was like this - maybe they updated snowflake tasks

Copy link
Contributor

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@thomasyu888 thomasyu888 merged commit 3905aa8 into dev Apr 23, 2024
3 checks passed
@thomasyu888 thomasyu888 deleted the unify-tasks branch May 25, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants