Extract ip addresses #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanFauble
reviewed
Apr 15, 2024
thomasyu888
commented
Apr 15, 2024
|
BryanFauble
reviewed
Apr 17, 2024
BryanFauble
reviewed
Apr 17, 2024
sage/ip_lookup.py
Outdated
| ip_info_response = requests.post('http://ip-api.com/batch', json=ip_list) | ||
| except Exception as err: | ||
| print(ip_info_response.status_code) | ||
| if ip_info_response.status_code == 429: |
There was a problem hiding this comment.
Future change would be to use the backoff package.
BryanFauble
reviewed
Apr 17, 2024
BryanFauble
reviewed
Apr 17, 2024
BryanFauble
approved these changes
Apr 17, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It would be nice if we gathered the individual IP address information so we can make interesting analysis around cost and usage.
Solution
Leveraging a free API to extract the IP information and pushing it to a snowflake table.
Admittedly, the code is a bit hacky right now...