Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SNOW-224] Remove CI race condition #156

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

philerooski
Copy link
Collaborator

Currently, our CI job executes all its jobs at once, although the order in which those jobs runs may be important. I added needs fields to each job which should wait for the successful completion of another job before running. I also removed some unused, commented-out lines and reordered the jobs in the ci.yaml file itself so that they are ordered according to the order in which they will execute (this is why it looks like the changes are more drastic than they really are).

@philerooski philerooski requested a review from a team as a code owner February 25, 2025 23:58
Copy link
Contributor

@danlu1 danlu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for working on it. It looks good to me. My understanding is the we will implement changes for objects in the datawarehouse (dev and prod) before fine tuning/ updating account level setting to avoid privilege issue when modifying the datawarehouse.

@philerooski
Copy link
Collaborator Author

@danlu1 That's one way of looking at it. I tried to mirror the order in which schemachange applies versioned vs. repeatable scripts:

  1. non-admin schemachange scripts
  2. admin schemachange scripts
  3. admin snowsql scripts

(3) is analogous to schemachange repeatable scripts, which normally run after schemachange versioned scripts, so we mirror that behavior here in the ordering 2 → 3.

@philerooski philerooski merged commit d5d311a into main Feb 26, 2025
3 checks passed
@philerooski philerooski deleted the snow-224-remove-ci-race-condition branch February 26, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants