Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused roles and tables #134

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Drop unused roles and tables #134

merged 1 commit into from
Feb 17, 2025

Conversation

philerooski
Copy link
Collaborator

We no longer have a need for these database roles or tables.

Depends on #133

@philerooski philerooski requested a review from a team as a code owner February 7, 2025 21:50
Copy link

dpulls bot commented Feb 10, 2025

🎉 All dependencies have been resolved !

Copy link
Contributor

@jaymedina jaymedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomasyu888 this is ready to merge, but I'll wait until the most recent dev is rebased onto main because there is a V script in here I'd like to verify after it's merged into dev. Thanks for working on this with me!

@thomasyu888
Copy link
Member

@thomasyu888 this is ready to merge, but I'll wait until the most recent dev is rebased onto main because there is a V script in here I'd like to verify after it's merged into dev. Thanks for working on this with me!

@jaymedina can you double check, I merged everything from main into dev already

@jaymedina
Copy link
Contributor

@thomasyu888 there is one straggler commit here that I'd like to see in main before I merge this in. That commit contains the admin scripts that will create our new proxy role which assumes ownership of ephemeral objects that communicate with other schemas, like tasks & dynamic tables.

@thomasyu888
Copy link
Member

thomasyu888 commented Feb 10, 2025

@thomasyu888 there is one straggler commit here that I'd like to see in main before I merge this in. That commit contains the admin scripts that will create our new proxy role which assumes ownership of ephemeral objects that communicate with other schemas, like tasks & dynamic tables.

@jaymedina Ah, thanks for the clarification. I created this PR: #138

@jaymedina
Copy link
Contributor

LGTM! Feel free to merge @philerooski

@philerooski philerooski force-pushed the drop-unused-resources branch from e2ddf2f to 01571cd Compare February 17, 2025 22:36
@philerooski philerooski merged commit 3473d73 into dev Feb 17, 2025
3 checks passed
@philerooski philerooski deleted the drop-unused-resources branch February 17, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants