Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SNOW-218] Create proxy admin database role #131

Merged
merged 6 commits into from
Feb 10, 2025
Merged

Conversation

philerooski
Copy link
Collaborator

@philerooski philerooski commented Feb 6, 2025

synapse_data_warehouse/database_roles/V2.38.0__proxy_admin_role.sql

Create the proxy admin database role. Grant ownership and usage to the admin account role. (Will run in both dev and prod).

admin/ownership_grants/V1.6.0__proxy_admin_role_dev.sql and admin/ownership_grants/V1.6.1__proxy_admin_role_prod.sql

Grant the proxy admin database role ownership and usage of *ALL_ADMIN database roles. Dev and prod, respectively.

admin/ownership_grants/V1.6.2__internamespace_object_ownership_dev.sql and admin/ownership_grants/V1.6.3__internamespace_object_ownership_prod.sql

Transfer ownership of our internamespace objects from SYSADMIN to the proxy admin database role. Dev and prod, respectively.

admin/future_grants/V1.6.4__internamespace_object_ownership_dev.sql and admin/future_grants/V1.6.5__internamespace_object_ownership_prod.sql

Grant ownership of future objects which potentially require internamespace privileges to the proxy admin database role. Dev and prod, respectively.

Depends on #133

@philerooski philerooski requested a review from a team as a code owner February 6, 2025 21:25
Copy link
Contributor

@jaymedina jaymedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few comments. Thanks for working on this ⚡

Copy link
Contributor

@danlu1 danlu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philerooski philerooski force-pushed the snow-218-proxy-admin-role branch from a871eeb to 0fc32ff Compare February 6, 2025 23:56
Copy link

sonarqubecloud bot commented Feb 7, 2025

Copy link

dpulls bot commented Feb 10, 2025

🎉 All dependencies have been resolved !

@jaymedina
Copy link
Contributor

@thomasyu888 now that #133 is merged, it's no longer a blocker for this PR, which looks ready to go. If you're onboard with this I'd like to merge this into dev and rebase dev back onto main so these admin scripts can be executed.

@thomasyu888
Copy link
Member

thomasyu888 commented Feb 10, 2025

@thomasyu888 now that #133 is merged, it's no longer a blocker for this PR, which looks ready to go. If you're onboard with this I'd like to merge this into dev and rebase dev back onto main so these admin scripts can be executed.

@jaymedina Feel free to merge! Thanks!

@jaymedina jaymedina merged commit 86a97c2 into dev Feb 10, 2025
3 checks passed
@jaymedina jaymedina deleted the snow-218-proxy-admin-role branch February 11, 2025 02:04
philerooski added a commit that referenced this pull request Feb 12, 2025
* Create proxy admin database role

* Grant proxy admin role ownership of *ALL_ADMIN roles

* Transfer ownership of current and future internamespace objects

* address PR comments

* bump version to avoid conflict

* grant execute managed task privilege to proxy admin
philerooski added a commit that referenced this pull request Feb 13, 2025
* Create proxy admin database role

* Grant proxy admin role ownership of *ALL_ADMIN roles

* Transfer ownership of current and future internamespace objects

* address PR comments

* bump version to avoid conflict

* grant execute managed task privilege to proxy admin
philerooski added a commit that referenced this pull request Feb 13, 2025
* [SNOW-218] Create proxy admin database role (#131)

* Create proxy admin database role

* Grant proxy admin role ownership of *ALL_ADMIN roles

* Transfer ownership of current and future internamespace objects

* address PR comments

* bump version to avoid conflict

* grant execute managed task privilege to proxy admin

* bump version and syntax fix
philerooski added a commit that referenced this pull request Feb 13, 2025
* [SNOW-218] Create proxy admin database role (#131)

* Create proxy admin database role

* Grant proxy admin role ownership of *ALL_ADMIN roles

* Transfer ownership of current and future internamespace objects

* address PR comments

* bump version to avoid conflict

* grant execute managed task privilege to proxy admin

* bump version and syntax fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants