-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create GENIE tables #13
Conversation
genie/genie_elt.py
Outdated
.replace("-public", "") | ||
) | ||
release_id = release['id'] | ||
release_files = syn.getChildren(release_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default this may include more than just the Files you intend to retrieve:
https://python-docs.synapse.org/reference/client/?h=getchildren#synapseclient.Synapse.getChildren
It may include other entity types
|
||
config = dotenv_values("../.env") | ||
|
||
ctx = snowflake.connector.connect( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to handle any context management here to close the connection? Not sure how this piece works internally.
genie/genie_elt.py
Outdated
comment="#", | ||
low_memory=False | ||
) | ||
write_pandas( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you required to commit after writing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few questions, otherwise LGTM!
|
|
No description provided.