Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GENIE tables #13

Merged
merged 11 commits into from
Apr 16, 2024
Merged

Create GENIE tables #13

merged 11 commits into from
Apr 16, 2024

Conversation

thomasyu888
Copy link
Member

No description provided.

.replace("-public", "")
)
release_id = release['id']
release_files = syn.getChildren(release_id)
Copy link
Contributor

@BryanFauble BryanFauble Jan 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default this may include more than just the Files you intend to retrieve:
https://python-docs.synapse.org/reference/client/?h=getchildren#synapseclient.Synapse.getChildren

It may include other entity types


config = dotenv_values("../.env")

ctx = snowflake.connector.connect(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to handle any context management here to close the connection? Not sure how this piece works internally.

comment="#",
low_memory=False
)
write_pandas(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you required to commit after writing?

Copy link
Contributor

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions, otherwise LGTM!

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

6 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@thomasyu888 thomasyu888 merged commit 62e428e into dev Apr 16, 2024
3 checks passed
@thomasyu888 thomasyu888 deleted the create-genie branch May 25, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants