-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SNOW-180] nodesnapshots
: Add columns related to project size and size limit
#106
Conversation
synapse_data_warehouse/synapse_raw/tables/V2.32.2__refresh_nodesnapshots.sql
Outdated
Show resolved
Hide resolved
@philerooski Marco's PRs that this PR depends on (linked above) are still waiting for review which means the data isn't ready yet and we don't have anything to test with in the dev stack. I'd rather have something to test with and backfill than not have something to test with and push straight to production, so I've preemptively added a Feel free to start reviewing these edits - I based them off Marco's current PR so things like the column name, etc are subject to change. |
🎉 All dependencies have been resolved ! |
I just ran 2.32.0 and 2.32.2 on my clone DB and it doesn't seem like there is any new data to test with yet (my |
synapse_data_warehouse/synapse_raw/V2.32.0__add_project_metadata_columns_nodesnapshots.sql
Outdated
Show resolved
Hide resolved
@jaymedina potentially related https://sagebionetworks.jira.com/browse/SNOW-216 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to either modify your backfill script (V2.32.2) or test deploying your V scripts to a clone with a local installation of schemachange (see review comments). Re-request my review once you're happy with any changes you might make.
...se_data_warehouse/synapse_raw/tables/V2.32.0__add_project_metadata_columns_nodesnapshots.sql
Outdated
Show resolved
Hide resolved
synapse_data_warehouse/synapse_raw/tables/V2.32.2__refresh_nodesnapshots.sql
Outdated
Show resolved
Hide resolved
synapse_data_warehouse/synapse_raw/tables/V2.32.2__refresh_nodesnapshots.sql
Outdated
Show resolved
Hide resolved
|
problem
Platform has added new metadata related to project sizes and size limits for users to access via Snowflake. The current table structure for
nodesnapshots
does not include these new columns and must be added.solution
Following this SOP:
nodesnapshots
tabletesting
Depends on Sage-Bionetworks/Synapse-Stack-Builder#688
Depends on Sage-Bionetworks/Synapse-Repository-Services#5221
A query of the
synapse_data_warehouse_jmedina.synapse_raw.nodesnapshots
table hasproject_storage_usage
backfilled since Jan 16, when the field was first introduced:53,620 rows for this field on dev as of today (Jan 29)
All of these rows have the correct
projectId
field, implying that theproject_storage_usage
metadata for each row is corresponding to the correct node: