Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precommit and run on all files #1541

Merged
merged 10 commits into from
Dec 18, 2024
Merged

Add precommit and run on all files #1541

merged 10 commits into from
Dec 18, 2024

Conversation

thomasyu888
Copy link
Member

Adds precommit so that development goes easier

@thomasyu888 thomasyu888 changed the title Add precommit Add precommit and run on all files Nov 14, 2024
@thomasyu888 thomasyu888 marked this pull request as ready for review November 19, 2024 07:09
@thomasyu888 thomasyu888 requested a review from a team as a code owner November 19, 2024 07:09
Copy link
Collaborator

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully isort is an easy fix, I like not needing to think about adding imports in certain locations - No biggie though.

Thanks for running this on all files, current PR's are going to run into merge conflicts because of the sheer number of changes, but, it's a bandage we need to rip off at some point.

@thomasyu888
Copy link
Member Author

Hopefully isort is an easy fix, I like not needing to think about adding imports in certain locations - No biggie though.

Thanks for running this on all files, current PR's are going to run into merge conflicts because of the sheer number of changes, but, it's a bandage we need to rip off at some point.

I'll wait for all your PRs to go in, and I'm happy to fix the merge conflicts since it'll be easier to fix on my end

@thomasyu888 thomasyu888 reopened this Nov 29, 2024
@thomasyu888 thomasyu888 marked this pull request as draft November 29, 2024 00:10
@thomasyu888 thomasyu888 marked this pull request as ready for review December 17, 2024 07:05
@BWMac
Copy link
Collaborator

BWMac commented Dec 17, 2024

#1560 is merged, good to go when ready.

@thomasyu888 thomasyu888 merged commit 1c68964 into develop Dec 18, 2024
8 checks passed
@thomasyu888 thomasyu888 deleted the add-precommit branch December 18, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants