-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add precommit and run on all files #1541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully isort is an easy fix, I like not needing to think about adding imports in certain locations - No biggie though.
Thanks for running this on all files, current PR's are going to run into merge conflicts because of the sheer number of changes, but, it's a bandage we need to rip off at some point.
I'll wait for all your PRs to go in, and I'm happy to fix the merge conflicts since it'll be easier to fix on my end |
#1560 is merged, good to go when ready. |
Quality Gate passedIssues Measures |
Adds precommit so that development goes easier