Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Manifest Generation Tests to Common Testing Branch #1515

Conversation

BWMac
Copy link
Collaborator

@BWMac BWMac commented Oct 3, 2024

This PR adds tests for the second (test_single_manifest_generation_google_sheet_no_annotations) and fourth (test_manifest_generation_multiple_blank_google_sheets) use cases in the test plan. I followed the example set in the existing tests and updated the new tests to use the logic for testing on different deployments/local flask server.

@BWMac BWMac marked this pull request as ready for review October 4, 2024 15:43
@BWMac BWMac requested a review from BryanFauble October 4, 2024 15:43
@BWMac BWMac changed the title DRAFT - Adds Manifest Generation Tests Adds Manifest Generation Tests to Common Testing Branch Oct 4, 2024
Copy link
Collaborator

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 comment for the URL, otherwise looks great!

@BWMac BWMac merged commit 423c78e into fds-2491-programatic-checking-of-schematic-api-test-plan Oct 4, 2024
2 checks passed
@BWMac BWMac deleted the bwmac/adds_menifest_generation_tests branch October 4, 2024 18:32
Copy link

sonarqubecloud bot commented Oct 4, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants