-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Manifest Generation Tests to Common Testing Branch #1515
Merged
BWMac
merged 6 commits into
fds-2491-programatic-checking-of-schematic-api-test-plan
from
bwmac/adds_menifest_generation_tests
Oct 4, 2024
Merged
Adds Manifest Generation Tests to Common Testing Branch #1515
BWMac
merged 6 commits into
fds-2491-programatic-checking-of-schematic-api-test-plan
from
bwmac/adds_menifest_generation_tests
Oct 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanFauble
reviewed
Oct 3, 2024
BryanFauble
reviewed
Oct 3, 2024
BryanFauble
reviewed
Oct 3, 2024
…n' into bwmac/adds_menifest_generation_tests
BWMac
changed the title
DRAFT - Adds Manifest Generation Tests
Adds Manifest Generation Tests to Common Testing Branch
Oct 4, 2024
BryanFauble
reviewed
Oct 4, 2024
BryanFauble
reviewed
Oct 4, 2024
BryanFauble
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 comment for the URL, otherwise looks great!
BWMac
merged commit Oct 4, 2024
423c78e
into
fds-2491-programatic-checking-of-schematic-api-test-plan
2 checks passed
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the second (
test_single_manifest_generation_google_sheet_no_annotations
) and fourth (test_manifest_generation_multiple_blank_google_sheets
) use cases in the test plan. I followed the example set in the existing tests and updated the new tests to use the logic for testing on different deployments/local flask server.