fix: updated test after updating to synapse python client 4.4.0 and updated test after test resources get updated on synapse

[linglp]

Problem:

I noticed the following test failed in develop:

FAILED tests/test_store.py::TestSynapseStorage::test_store_async_annotation - AssertionError: expected call not found.

And also this test failed:

FAILED tests/test_manifest.py::TestManifestGenerator::test_get_manifest_with_files[File based] 

Related to: https://sagebionetworks.jira.com/browse/FDS-2304

Reason

left over from: #1468. After updating to synapse python client, this test needs to be updated

And also the following tests were skipped in github action run:

[gw0] [ 86%] SKIPPED tests/test_store.py::TestSynapseStorage::test_format_row_annotations_entity_id_trash_can[True-display_label] 
tests/test_store.py::TestSynapseStorage::test_format_row_annotations_entity_id_trash_can[False-display_label] 
[gw0] [ 86%] SKIPPED tests/test_store.py::TestSynapseStorage::test_format_row_annotations_entity_id_trash_can[False-display_label] 
tests/test_store.py::TestSynapseStorage::test_format_row_annotations_entity_id_trash_can[True-class_label] 
[gw0] [ 86%] SKIPPED tests/test_store.py::TestSynapseStorage::test_format_row_annotations_entity_id_trash_can[True-class_label] 
tests/test_store.py::TestSynapseStorage::test_format_row_annotations_entity_id_trash_can[False-class_label] 
[gw0] [ 86%] SKIPPED tests/test_store.py::TestSynapseStorage::test_format_row_annotations_entity_id_trash_can[False-class_label] 
tests/test_store.py::TestSynapseStorage::test_get_files_metadata_from_dataset 
[gw0] [ 86%] PASSED tests/test_store.py::TestSynapseStorage::test_get_files_metadata_from_dataset 
tests/test_store.py::TestSynapseStorage::test_get_async_annotation 
[gw0] [ 87%] SKIPPED tests/test_store.py::TestSynapseStorage::test_get_async_annotation 
tests/test_store.py::TestSynapseStorage::test_store_async_annotation 
[gw0] [ 87%] SKIPPED tests/test_store.py::TestSynapseStorage::test_store_async_annotation 
tests/test_store.py::TestSynapseStorage::test_process_store_annos_failure 
[gw0] [ 87%] SKIPPED tests/test_store.py::TestSynapseStorage::test_process_store_annos_failure 
tests/test_store.py::TestSynapseStorage::test_process_store_annos_success_store 
[gw0] [ 87%] SKIPPED tests/test_store.py::TestSynapseStorage::test_process_store_annos_success_store 
tests/test_store.py::TestSynapseStorage::test_process_store_annos_success_get 
[gw0] [ 87%] SKIPPED tests/test_store.py::TestSynapseStorage::test_process_store_annos_success_get 
tests/test_store.py::TestSynapseStorage::test_process_store_annos_success_get_entity_id_variants 
[gw0] [ 87%] SKIPPED tests/test_store.py::TestSynapseStorage::test_process_store_annos_success_get_entity_id_variants 
tests/test_store.py::TestSynapseStorage::test_process_store_annos_get_annos_empty 
[gw0] [ 87%] SKIPPED tests/test_store.py::TestSynapseStorage::test_process_store_annos_get_annos_empty 
tests/test_store.py::TestDatasetFileView::test_init 

Solution

• update the test to use the new method from synapse python client
• investigate why the tests were skipped will be in a separate ticket: FDS 2305

[thomasyu888]

LGTM! Is this tied to the jira ticket?

[linglp]

LGTM! Is this tied to the jira ticket?

Thanks Tom. I also want to see why this test was skipped.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[linglp]

LGTM! Is this tied to the jira ticket?

Yeah. I updated the PR description.