Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set annotations in an async way when submitting a manifest #1440

Merged
merged 25 commits into from
Jun 21, 2024

Conversation

linglp
Copy link
Contributor

@linglp linglp commented Jun 7, 2024

Context

related to: FDS-2113 Store annotations in an async way when submitting manifests
The speed of submitting manifest when storing annotation in a synchronous way is like ~10min

Major changes

  • Per communication with Bryan, I updated the code to get annotations and store annotations in an async way
  • update synapseclient to 4.3.0 to avoid timeout error in 4.2.0

Benchmarking

With the help of tracing, I was able to benchmark manifest submission with the new change.

For submitting a manifest locally with file_only option and file_annotations_upload=True option for 3000 files:

In my local environment, with async:

  • the speed is around 5min 12s, the longest latency was 5min 39 second, and the shortest latency was 4min 38 seconds.

Using aws-dev environment to test, with async:

  • the speed is around 4min 40s, the longest latency was 4min 50 seconds, and the shortest latency is 4min 30 seconds.

@BryanFauble
Copy link
Collaborator

I like the direction of your changes here. Great work!

Copy link
Collaborator

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments around areas to give some more thought. Otherwise this is great!

tests/test_store.py Outdated Show resolved Hide resolved
schematic/store/synapse.py Show resolved Hide resolved
schematic/store/synapse.py Show resolved Hide resolved
tests/test_store.py Outdated Show resolved Hide resolved
Copy link

@linglp linglp merged commit 4795cd1 into develop Jun 21, 2024
4 checks passed
@linglp linglp deleted the develop-async-set-annotation branch June 21, 2024 14:35
@linglp linglp restored the develop-async-set-annotation branch June 27, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants