Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add maintainers and version info to AWS Docker image #1437

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Add maintainers and version info to AWS Docker image #1437

merged 4 commits into from
Jun 12, 2024

Conversation

GiaJordan
Copy link
Contributor

@GiaJordan GiaJordan commented Jun 5, 2024 •
edited
Loading

Resolves FDS-674

@GiaJordan GiaJordan changed the title Add lables to docker container Add maintainers and version info to docker container Jun 5, 2024
@GiaJordan GiaJordan marked this pull request as draft June 5, 2024 18:13
@GiaJordan GiaJordan changed the title Add maintainers and version info to docker container Add maintainers and version info to AWS Docker image Jun 5, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@GiaJordan GiaJordan requested a review from linglp June 6, 2024 17:06
@GiaJordan GiaJordan marked this pull request as ready for review June 6, 2024 17:06
@linglp
Copy link
Contributor

linglp commented Jun 11, 2024

@GiaJordan here it looks like that there are a lot of changes. What are the actual changes?

@GiaJordan
Copy link
Contributor Author

GiaJordan commented Jun 11, 2024 •
edited
Loading

@GiaJordan here it looks like that there are a lot of changes. What are the actual changes?

Enable the "hide whitespace" setting to hide the line ending changes @linglp

image

@linglp
Copy link
Contributor

linglp commented Jun 11, 2024 •
edited
Loading

@GiaJordan Oh I see. That makes sense. I tried validating by building a docker image using your branch, and I could see maintainer info be added:
Screen Shot 2024-06-11 at 1 28 58 PM

which is different from the current one:
Screen Shot 2024-06-11 at 1 30 19 PM

But I don't see a change in the version tag:
Screen Shot 2024-06-11 at 1 34 19 PM
which seems like the same for the old one:
Screen Shot 2024-06-11 at 1 35 13 PM

Is this expected?

@GiaJordan
Copy link
Contributor Author

@linglp yes, the version tag is new, and that is expected

@linglp linglp self-requested a review June 12, 2024 15:58
linglp
linglp approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@linglp linglp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve now. Thanks @GiaJordan

@GiaJordan GiaJordan merged commit 423650c into develop Jun 12, 2024
6 checks passed
@GiaJordan GiaJordan deleted the develop-docker-info-FDS-674 branch June 12, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linglp linglp linglp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GiaJordan @linglp