Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

154 add challenge properties for header #155

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

tschaffter
Copy link
Member

@tschaffter tschaffter commented Sep 8, 2021

Fixes #154

Notes

  • Limited validation is performed (e.g. the platform ID submitted when creating a challenge is now validated to check if it belongs to an existing platform). Extra validation will be added in a separate PR.

@tschaffter tschaffter self-assigned this Sep 8, 2021
@tschaffter
Copy link
Member Author

Here are an example of challenge returned:

{
  "description": "This challenge is awesome.",
  "displayName": "Awesome Challenge",
  "endDate": "2020-12-31T00:00:00Z",
  "fullName": "awesome-user/awesome-challenge",
  "id": "6138f253137b9b4fbf247290",
  "name": "awesome-challenge",
  "ownerId": "6138f250137b9b4fbf24728f",
  "startDate": "2020-11-10T00:00:00Z",
  "status": "active"
}

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1214301528

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 29 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 46.463%

Files with Coverage Reduction New Missed Lines %
openapi_server/dbmodels/challenge.py 3 85.71%
openapi_server/controllers/challenge_controller.py 26 18.07%
Totals Coverage Status
Change from base Build 1199481596: 0.2%
Covered Lines: 1143
Relevant Lines: 2460

💛 - Coveralls

@tschaffter tschaffter requested a review from rrchai September 8, 2021 17:30
Copy link

@rrchai rrchai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thank you

@tschaffter tschaffter merged commit 6ac1683 into main Sep 8, 2021
@tschaffter tschaffter deleted the 154-add-challenge-properties-for-header branch September 8, 2021 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Challenge properties required for the challenge header
3 participants