Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IBCDPE-765] Adds biodomain_info GX Suite #142

Merged
merged 3 commits into from
Jul 18, 2024
Merged

[IBCDPE-765] Adds biodomain_info GX Suite #142

merged 3 commits into from
Jul 18, 2024

Conversation

BWMac
Copy link
Contributor

@BWMac BWMac commented Jul 17, 2024 •
edited
Loading

Description:

This PR implements a GX expectation suite for the biodomain_info dataset.

I used the rules here and here as reference.

An example report file can be viewed here.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@BWMac BWMac marked this pull request as ready for review July 17, 2024 20:49
JessterB
JessterB approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@JessterB JessterB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BWMac BWMac merged commit b5b2c65 into dev Jul 18, 2024
9 checks passed
@BWMac BWMac deleted the bwmac/IBCDPE-765/biodomain_info_gx branch July 18, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JessterB JessterB JessterB approved these changes

@jaclynbeck-sage jaclynbeck-sage Awaiting requested review from jaclynbeck-sage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BWMac @JessterB