[IBCDPE-797] Adds target_exp_validation_harmonized Expectation Suite
#126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BWMac
commented
Feb 29, 2024
jaclynbeck-sage
approved these changes
Mar 1, 2024
JessterB
reviewed
Mar 2, 2024
src/agoradatatools/great_expectations/gx/expectations/target_exp_validation_harmonized.json
Show resolved
Hide resolved
src/agoradatatools/great_expectations/gx/expectations/target_exp_validation_harmonized.json
Show resolved
Hide resolved
src/agoradatatools/great_expectations/gx/expectations/target_exp_validation_harmonized.json
Show resolved
Hide resolved
|
JessterB
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements a GX expectation suite for the
target_exp_validation_harmonizeddataset.Please let me know if there are any additional expectations I should add, or if there are any adjustments to be made to the expectations I have already implemented. In particular, there are a handful of fields that appear to be "open text" fields (such as
hypothesis). I wasn't sure which expectations to apply other than expecting them to be strings and to have a length in a wide range.Notes:
Values I have chosen for expectations like expect_column_values_to_be_between are based on looking at the example dataset on Synapse.
This change has been tested by running adt test_config.yaml. Example results can be downloaded here.