Skip to content
This repository has been archived by the owner on Jan 19, 2025. It is now read-only.

feat: Automatisierte Herleitung von Optional Annotations #473

Merged

Conversation

Masara
Copy link
Contributor

@Masara Masara commented May 6, 2022

Closes #443.

Summary of Changes

Add automated generation of optional annotations.

GideonKoenig and others added 30 commits April 22, 2022 16:42
…rleitung-von-required-annotations

# Conflicts:
#	package-parser/package-parser.iml
#	package-parser/package_parser/commands/generate_annotations/generate_annotations.py
#	package-parser/tests/commands/generate_annotations/test_generate_annotations.py
… into 443-automatisierte-herleitung-von-optional-annotations

# Conflicts:
#	package-parser/package_parser/commands/generate_annotations/generate_annotations.py
… of github.com:lars-reimann/api-editor into 442-automatisierte-herleitung-von-required-annotations
Improved auxiliary functions
Added ParameterInfo Class to communicate the return values of functions better
Migrated said ParameterInfo and ParameterType classes to annotation_model.py
Test is now working - all is good
… of github.com:lars-reimann/api-editor into 442-automatisierte-herleitung-von-required-annotations
…ter should be optional or required for more clarity
… into 443-automatisierte-herleitung-von-optional-annotations

# Conflicts:
#	package-parser/package_parser/commands/generate_annotations/generate_annotations.py
#	package-parser/tests/commands/generate_annotations/test_generate_annotations.py
…to the new data class structure and adjusted the optional annotation test.
@jofaul jofaul self-requested a review May 6, 2022 09:25
@jofaul jofaul self-assigned this May 6, 2022
@github-actions
Copy link

github-actions bot commented May 6, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 3.43s
✅ GIT git_diff yes no 0.01s
✅ PYTHON black 2 0 0 0.48s
✅ PYTHON isort 2 0 0 0.18s
✅ PYTHON mypy 2 0 30.66s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

jofaul
jofaul previously approved these changes May 6, 2022
Copy link
Contributor

@jofaul jofaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vorsicht: Hat Required Branch integriert, vielleicht Required zuerst mergen. Sonst super

@jofaul jofaul requested a review from lars-reimann May 6, 2022 09:33
@jofaul jofaul added enhancement 💡 New feature or request annotations labels May 6, 2022
@Masara
Copy link
Contributor Author

Masara commented May 6, 2022

@lars-reimann

@lars-reimann lars-reimann merged commit fd5816a into main May 6, 2022
@lars-reimann lars-reimann deleted the 443-automatisierte-herleitung-von-optional-annotations branch May 6, 2022 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement 💡 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatisierte Herleitung von Optional Annotations
4 participants