Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AE stage 1 #1360

Merged
merged 20 commits into from
Feb 8, 2024
Merged

add AE stage 1 #1360

merged 20 commits into from
Feb 8, 2024

Conversation

bjjwwang
Copy link
Contributor

@bjjwwang bjjwwang commented Feb 6, 2024

No description provided.

@@ -444,7 +444,7 @@ bool AE::hasSwitchBranchES(const SVFVar* var, s64_t succ, IntervalExeState& es)
}
while(!workList.empty()) {
const SVFStmt* stmt = workList.pop();
if (const CopyStmt *copy = SVFUtil::dyn_cast<CopyStmt>(stmt)) {
if (SVFUtil::dyn_cast<CopyStmt>(stmt)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVFUtil::isa(stmt)

and fix all others below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. it has been fixed.

using namespace SVF;
using namespace SVFUtil;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why add this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
I remove 'using namespace llvm'
and remain the SVFUtil in latest commit

@@ -722,7 +722,7 @@ const Option<bool> Options::VtableInSVFIR(
const Option<std::string> Options::ExtAPIPath(
"extapi",
"External API extapi.bc",
""
"/Users/z5489735/2023/0106/SVF/extapi.bc"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
It is dirty code, I remove it.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 199 lines in your changes are missing coverage. Please review.

Comparison is base (3893fe5) 66.13% compared to head (ba855ed) 67.83%.
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1360      +/-   ##
==========================================
+ Coverage   66.13%   67.83%   +1.69%     
==========================================
  Files         227      253      +26     
  Lines       24648    27717    +3069     
==========================================
+ Hits        16302    18802    +2500     
- Misses       8346     8915     +569     
Files Coverage Δ
svf-llvm/tools/AE/ae.cpp 100.00% <100.00%> (ø)
svf-llvm/tools/Example/svf-ex.cpp 36.66% <ø> (ø)
svf/include/AE/Core/AbstractValue.h 100.00% <ø> (ø)
svf/include/AE/Core/BoundedZ3Expr.h 65.11% <ø> (ø)
svf/include/AE/Core/CFBasicBlockGWTO.h 100.00% <100.00%> (ø)
svf/include/AE/Core/ExeState.h 45.31% <ø> (ø)
svf/include/AE/Core/IntervalExeState.h 65.71% <ø> (ø)
svf/include/AE/Core/IntervalValue.h 78.16% <ø> (ø)
svf/include/AE/Core/NumericLiteral.h 76.80% <ø> (ø)
svf/include/AE/Core/RelExeState.h 29.41% <ø> (ø)
... and 16 more

... and 25 files with indirect coverage changes

#include "SVFIR/SVFType.h"
#include "AbstractExecution/BoundedZ3Expr.h"
#include "Util/GeneralType.h"
#include "BoundedZ3Expr.h"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add folder name

clean some code
@yuleisui yuleisui merged commit e2224fc into SVF-tools:master Feb 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants