forked from cloudfoundry/stratos
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge upstream #402
Merged
Merged
Merge upstream #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few more store -> core dependency fixes
Last set of store -> core dependency removals
# Conflicts: # angular.json # package-lock.json # src/frontend/packages/cloud-foundry/src/shared/components/service-plan-public/service-plan-public.component.ts
Fix duplicated k8s docs
… Entities (cloudfoundry#4387) * WIP * WIP * WIP * Endpoint changes * Fix failure handling during connect on stepper * Fix favourites * Removed some TODOs * Fixes & todos * Unit test fixes * Fixes following merge * Fix cf unit tests * Changes following review
Rejig example extensions for V4 build
Co-authored-by: Neil MacDougall <neil.macdougall@suse.com>
Build devkit outside of dist folder
…ements Theming improvements for page header
* Remove action entityLocation (not used) * Fix restage - fixes cloudfoundry#4392 * Remove RequestEntityLocation
* Update icons * Update docker icon and optimize other pngs * Improve resolution of container icon * Update e2e test for new icons
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
==========================================
- Coverage 56.48% 56.47% -0.01%
==========================================
Files 886 886
Lines 28978 28963 -15
Branches 4215 4213 -2
==========================================
- Hits 16368 16358 -10
+ Misses 12610 12605 -5 |
nwmac
approved these changes
Jun 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains