Registry cache #220
Registry cache #220
Conversation
brunoleon
commented
Nov 9, 2020
brunoleon
commented
brunoleon
force-pushed
the
registry_cache
branch
from
2c1712d to
1abab0a
Compare
| </ip> | ||
| </network> | ||
| """ % { | ||
| <network xmlns:dnsmasq='http://libvirt.org/schemas/network/dnsmasq/1.0'> |
There was a problem hiding this comment.
- Can you keep the current indent please
There was a problem hiding this comment.
Actually I changed the current indent because it would not allow longer line.
I find it more readable to have most of the line on a single one.
There was a problem hiding this comment.
Instead of playing with dedenting and indentation, could you please move the template to a separate file and load if required. Use __file__ to determine relative path to it.
There was a problem hiding this comment.
Up until now it was preferred to have template within the code so I'm not sure about it, even though I tend to prefer it as you describe.
There was a problem hiding this comment.
Not sure, I never prefer mulitline xml code having in python module.
There was a problem hiding this comment.
If I saw the initial commit on review, I asked to move it out.
| </dhcp> | ||
| </ip> | ||
| <dnsmasq:options> | ||
| <dnsmasq:option value="address=/.local/%(registry_mirror)s"/> |
There was a problem hiding this comment.
What is this good for? I don't get it.
There was a problem hiding this comment.
This is needed to have the DNS setup by libvirt to resolve your cache registries (docker.io.local, registry.suse.de.local etc...) to the IP of registry_mirror_address
I actually passes options to dnsmasq
|
Could you please add some guidelines how to setup local container registry in the docs. |
brunoleon
force-pushed
the
registry_cache
branch
2 times, most recently
from
38a9583 to
1268167
Compare
This PR adds support for using a local registry cache in order to speedup deployments. Deployment of that registry is left out of rookckeck tool though.
brunoleon
force-pushed
the
registry_cache
branch
from
1268167 to
2eb4110
Compare
| @@ -55,3 +55,9 @@ _remove_workspace = true | |||
| # that ansible-playbook accepts for the --extra-vars parameter | |||
| # See https://docs.ansible.com/ansible/latest/user_guide/playbooks_variables.html#defining-variables-at-runtime # noqa | |||
| ansible_extra_vars = "" | |||
|
|
|||
| # container registry cache IP - This can be any IP as long as it is reachable by you cluster nodes. | |||
